Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.3 #796

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Add PHP8.3 #796

merged 3 commits into from
Dec 13, 2023

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Nov 24, 2023

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (219217b) 55.33% compared to head (f24fb47) 55.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files          75       75           
  Lines        8902     8902           
=======================================
  Hits         4926     4926           
  Misses       3976     3976           
Flag Coverage Δ
tests 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotani1111
Copy link
Contributor

dotani1111 commented Dec 4, 2023

@nanasess
5.4~8.3まで!ありがとうございます!
1部のAction落ちていますが、マージしても大丈夫でしょうか?

@nanasess
Copy link
Contributor Author

nanasess commented Dec 4, 2023

@dotani1111 落ちているのは PHP8.3 とは別の原因ですので、マージしていただいて大丈夫です!

@dotani1111 dotani1111 merged commit c438132 into EC-CUBE:master Dec 13, 2023
59 of 60 checks passed
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants